client/keys/parse.go: honor config changes #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boz
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze,
hschoenburg and
nylira
as code owners
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been For contributor use:
For admin use:
Thank you for your contribution to the Cosmos-SDK! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #6172 +/- ##
==========================================
- Coverage 54.79% 54.79% -0.01%
==========================================
Files 443 443
Lines 26704 26729 +25
==========================================
+ Hits 14633 14645 +12
- Misses 11032 11044 +12
- Partials 1039 1040 +1 |
`keys parse` uses the global configuration before before client applications have had a chance to apply their settings. This change adds a `GetSealedConfig()` helper that waits for the config to be sealed before returning it. fixes cosmos#5091 addresses cosmos#5283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keys parseuses the global configuration beforebefore client applications have had a chance to
apply their settings.
This change adds a
GetSealedConfig()helperthat waits for the config to be sealed before
returning it.
fixes #5091
addresses #5283